Skip to content

fix(deps)!: use grpc-js instead of grpc extension #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
callmehiphop merged 7 commits into from
Jun 14, 2019
Merged

fix(deps)!: use grpc-js instead of grpc extension #658

callmehiphop merged 7 commits into from
Jun 14, 2019

Conversation

@callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Jun 13, 2019 •
edited
Loading

Fixes #627

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2019
@codecov
Copy link

codecov bot commented Jun 13, 2019 •
edited
Loading

Codecov Report

Merging #658 into master will decrease coverage by 0.1%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   97.89%   97.79%   -0.11%     
==========================================
  Files          14       14              
  Lines         856      861       +5     
  Branches      178      179       +1     
==========================================
+ Hits          838      842       +4     
  Misses          2        2              
- Partials       16       17       +1
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️
src/message-queues.ts 100% <100%> (ø) ⬆️
src/pull-retry.ts 100% <100%> (ø) ⬆️
src/pubsub.ts 100% <100%> (ø) ⬆️
src/message-stream.ts 96.9% <83.33%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9972ea...753010c. Read the comment docs.

@callmehiphop
Copy link
Contributor Author

callmehiphop commented Jun 13, 2019

@sduskis I'm running some stress tests locally, but as of right now I think we're looking good. I wrote a new test specifically for messages that are 9mb and it appears to be working just fine.

@callmehiphop callmehiphop marked this pull request as ready for review June 13, 2019 20:15
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2019
@callmehiphop callmehiphop merged commit 535a917 into googleapis:master Jun 14, 2019
@yoshi-automation yoshi-automation mentioned this pull request Jun 14, 2019
Closed
@callmehiphop callmehiphop mentioned this pull request Jun 17, 2019
Merged
@alexbonhomme alexbonhomme mentioned this pull request Jul 16, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@feywind feywind mentioned this pull request Feb 7, 2020
Closed
This was referenced Apr 29, 2020
Closed
Closed
@feywind feywind mentioned this pull request May 20, 2020
Closed
@release-please release-please bot mentioned this pull request May 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcoe bcoe Awaiting requested review from bcoe

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

@sduskis sduskis Awaiting requested review from sduskis

2 more reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@ajaaym ajaaym ajaaym approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch from grpc to @grpc/grpc-js

5 participants

@callmehiphop @JustinBeckwith @ajaaym @googlebot @kokoro-team