Skip to content

fix(deps): update dependency p-defer to v3 #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
callmehiphop merged 2 commits into from
Jun 12, 2019
Merged

fix(deps): update dependency p-defer to v3 #650

callmehiphop merged 2 commits into from
Jun 12, 2019

Conversation

@callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Jun 11, 2019 •
edited
Loading

Closes #649

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@callmehiphop callmehiphop requested a review from a team June 11, 2019 17:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2019
@codecov
Copy link

codecov bot commented Jun 12, 2019 •
edited
Loading

Codecov Report

Merging #650 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          14       14           
  Lines         856      856           
  Branches      178      178           
=======================================
  Hits          838      838           
  Misses          2        2           
  Partials       16       16
Impacted Files Coverage Δ
src/message-queues.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a01be8...8649881. Read the comment docs.

@callmehiphop callmehiphop requested review from JustinBeckwith, bcoe and stephenplusplus and removed request for a team June 12, 2019 20:00
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@callmehiphop callmehiphop merged commit 50f9d4e into googleapis:master Jun 12, 2019
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@JustinBeckwith
fix: improve TypeScript types (googleapis#650)
b54830f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcoe bcoe Awaiting requested review from bcoe

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@callmehiphop @JustinBeckwith @googlebot @kokoro-team