Skip to content

fix: update regex to target correct comment #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
callmehiphop merged 3 commits into from
Jun 7, 2019
Merged

fix: update regex to target correct comment #646

callmehiphop merged 3 commits into from
Jun 7, 2019

Conversation

@callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Jun 7, 2019

Fixes #645

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2019
bcoe
bcoe approved these changes Jun 7, 2019
View reviewed changes
Copy link

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once linting passes, LGTM.

@codecov
Copy link

codecov bot commented Jun 7, 2019 •
edited
Loading

Codecov Report

Merging #646 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          14       14           
  Lines         856      856           
  Branches      178      178           
=======================================
  Hits          838      838           
  Misses          2        2           
  Partials       16       16
Impacted Files Coverage Δ
src/message-queues.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd54630...caf9dba. Read the comment docs.

@callmehiphop
Copy link
Contributor Author

callmehiphop commented Jun 7, 2019

:< looks like our linting rules had changed, so the failure was unrelated to this PR.

@callmehiphop callmehiphop merged commit 9e8f245 into googleapis:master Jun 7, 2019
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@JustinBeckwith
fix: improve TypeScript types (googleapis#646)
f4e1b86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JustinBeckwith JustinBeckwith Awaiting requested review from JustinBeckwith

1 more reviewer

@bcoe bcoe bcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

lint/docs tests appear to be breaking

3 participants

@callmehiphop @bcoe @googlebot