Skip to content

Conversation

@bcoe
Copy link

@bcoe bcoe commented Jun 1, 2019

This adds a .repo-metadata.json, which is used to automate publishing docs when new package versions are released.

This PR also re-runs our automated README generation, which is based on .repo-metadata.json as well.

I've left a couple questions for folks inline.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2019

'use strict';

// [START pubsub_quickstart_create_topic]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is renaming this region tag to the standard quickstart okay? CC: @sduskis, @JustinBeckwith, I wasn't sure how load bearing the region tag is, e.g., will this mean that we break samples on cloud.google.com?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is very likely to break samples. Can you follow up with @jmdobry or @fhinkel on the right way to change this?

@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

Merging #636 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          14       14           
  Lines         856      856           
  Branches      178      178           
=======================================
  Hits          838      838           
  Misses          2        2           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884711f...ef13724. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

Merging #636 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          14       14           
  Lines         856      856           
  Branches      178      178           
=======================================
  Hits          838      838           
  Misses          2        2           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884711f...47e3928. Read the comment docs.

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the nit about the region tag


'use strict';

// [START pubsub_quickstart_create_topic]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is very likely to break samples. Can you follow up with @jmdobry or @fhinkel on the right way to change this?

@bcoe bcoe merged commit 142f56c into master Jun 5, 2019
@bcoe bcoe deleted the repo-metadata branch June 5, 2019 15:03
jiren pushed a commit to jiren/nodejs-pubsub that referenced this pull request Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants