Skip to content

fix(subscription)!: decouple retainAckedMessages from messageRetentionDuration #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 2 commits into from
May 23, 2019
Merged

fix(subscription)!: decouple retainAckedMessages from messageRetentionDuration #625

sduskis merged 2 commits into from
May 23, 2019

Conversation

@callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented May 23, 2019 •
edited
Loading

Fixes #623

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@callmehiphop callmehiphop requested review from bcoe and sduskis May 23, 2019 21:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 23, 2019
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #625 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   97.89%   97.89%   -0.01%     
==========================================
  Files          14       14              
  Lines         857      856       -1     
  Branches      178      178              
==========================================
- Hits          839      838       -1     
  Misses          2        2              
  Partials       16       16
Impacted Files Coverage Δ
src/subscription.ts 99.18% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2167536...cb5c16d. Read the comment docs.

@sduskis sduskis merged commit 3431e7c into googleapis:master May 23, 2019
This was referenced May 23, 2019
Closed
Closed
@yoshi-automation yoshi-automation mentioned this pull request Jun 5, 2019
Closed
@callmehiphop callmehiphop mentioned this pull request Jun 17, 2019
Merged
@alexbonhomme alexbonhomme mentioned this pull request Jul 16, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
This was referenced Apr 29, 2020
Closed
Closed
@feywind feywind mentioned this pull request May 20, 2020
Closed
@release-please release-please bot mentioned this pull request May 20, 2020
Closed
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@summer-ji-eng
chore: update jsdoc.js (googleapis#625)
a54d5aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcoe bcoe Awaiting requested review from bcoe

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Decouple retainAckedMessages and messageRetentionDuration

3 participants

@callmehiphop @sduskis @googlebot