feat(subscription): ordered messages #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 94.82% 94.83% +<.01%
==========================================
Files 16 16
Lines 967 968 +1
Branches 86 86
==========================================
+ Hits 917 918 +1
Misses 42 42
Partials 8 8
Continue to review full report at Codecov.
|
JustinBeckwith
suggested changes
Mar 25, 2019
| * @type {string} | ||
| */ | ||
| this.ackId = ackId; | ||
| this.ackId = ackId!; |
Contributor
There was a problem hiding this comment.
Why is the ! needed here?
Contributor
Author
There was a problem hiding this comment.
I switched to use the generated types, before I just hand wrote it but I don't think we had a solution in place for that yet. As such, they mark everything as optional (even though that isn't necessarily the case)
JustinBeckwith
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add support for
orderingKeyin the handwritten layer.