Skip to content

fix(deps): update dependency p-defer to v2 #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
callmehiphop merged 3 commits into from
Mar 25, 2019
Merged

fix(deps): update dependency p-defer to v2 #553

callmehiphop merged 3 commits into from
Mar 25, 2019

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Mar 17, 2019 •
edited
Loading

This PR contains the following updates:

Package Type Update Change References
p-defer dependencies major ^1.0.0 -> ^2.0.0 source

Release Notes

sindresorhus/p-defer

v2.0.1

Compare Source

  • Make resolve and reject values optional in the TypeScript definition (#​3) f84a366

v2.0.0

Compare Source

Breaking:

Enhancements:

Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2019
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 18, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 18, 2019
@callmehiphop callmehiphop added the status: blocked Resolving the issue is dependent on other work. label Mar 18, 2019
@renovate renovate bot force-pushed the renovate/p-defer-2.x branch from ed1da65 to 13967e7 Compare March 20, 2019 01:24
@callmehiphop
Copy link
Contributor

callmehiphop commented Mar 21, 2019

This update comes with native types, however there is currently a bug with said types preventing us from upgrading. I've filed a PR with the fix in the mean time: sindresorhus/p-defer#3

@renovate renovate bot force-pushed the renovate/p-defer-2.x branch from 13967e7 to 27f78f8 Compare March 21, 2019 19:27
@renovate renovate bot force-pushed the renovate/p-defer-2.x branch from 27f78f8 to 1d977a9 Compare March 25, 2019 18:03
@googlebot
Copy link

googlebot commented Mar 25, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 25, 2019
@callmehiphop callmehiphop removed the status: blocked Resolving the issue is dependent on other work. label Mar 25, 2019
@renovate
Copy link
Contributor Author

renovate bot commented Mar 25, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 25, 2019
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2019
@codecov
Copy link

codecov bot commented Mar 25, 2019 •
edited
Loading

Codecov Report

Merging #553 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #553   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files          16       16           
  Lines         967      967           
  Branches       86       86           
=======================================
  Hits          917      917           
  Misses         42       42           
  Partials        8        8
Impacted Files Coverage Δ
src/message-queues.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae4719...0c24f98. Read the comment docs.

@callmehiphop
Copy link
Contributor

callmehiphop commented Mar 25, 2019

@JustinBeckwith can you fight da robots for mee please :)

@JustinBeckwith JustinBeckwith added cla: yes This human has signed the Contributor License Agreement. and removed 🚨 This issue needs some love. cla: no This human has *not* signed the Contributor License Agreement. labels Mar 25, 2019
@googlebot
Copy link

googlebot commented Mar 25, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 25, 2019
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2019
@callmehiphop callmehiphop merged commit fe33e40 into master Mar 25, 2019
@renovate renovate bot deleted the renovate/p-defer-2.x branch March 25, 2019 20:01
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@callmehiphop
chore: update CONTRIBUTING.md and make releaseType node (googleapis#553)
06ea588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@callmehiphop @googlebot @JustinBeckwith @kokoro-team @yoshi-automation