Skip to content

Commit 9e8f245

Browse files
authored
fix: update regex to target correct comment (#646)
1 parent cd54630 commit 9e8f245

File tree

4 files changed

+6
-16
lines changed

4 files changed

+6
-16
lines changed

samples/subscriptions.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,7 @@ async function createFlowControlledSubscription(
119119
autoCreate: true,
120120
});
121121
console.log(
122-
`Subscription ${
123-
newSubscription.name
124-
} created with a maximum of ${maxInProgress} unprocessed messages.`
122+
`Subscription ${newSubscription.name} created with a maximum of ${maxInProgress} unprocessed messages.`
125123
);
126124

127125
// [END pubsub_subscriber_flow_settings]
@@ -340,9 +338,7 @@ async function synchronousPull(projectName, subscriptionName) {
340338
await client.modifyAckDeadline(modifyAckRequest);
341339

342340
console.log(
343-
`Reset ack deadline for "${
344-
message.message.data
345-
}" for ${newAckDeadlineSeconds}s.`
341+
`Reset ack deadline for "${message.message.data}" for ${newAckDeadlineSeconds}s.`
346342
);
347343
}
348344
}

samples/system-test/topics.test.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,7 @@ describe('topics', () => {
163163
.get({autoCreate: true});
164164
const startTime = Date.now();
165165
execSync(
166-
`${cmd} publish-batch ${topicNameOne} "${
167-
expectedMessage.data
168-
}" -w ${waitTime}`
166+
`${cmd} publish-batch ${topicNameOne} "${expectedMessage.data}" -w ${waitTime}`
169167
);
170168

171169
const {data, publishTime} = await _pullOneMessage(subscription);
@@ -181,9 +179,7 @@ describe('topics', () => {
181179
.subscription(subscriptionNameFour)
182180
.get({autoCreate: true});
183181
execSync(
184-
`${cmd} publish-retry ${projectId} ${topicNameOne} "${
185-
expectedMessage.data
186-
}"`
182+
`${cmd} publish-retry ${projectId} ${topicNameOne} "${expectedMessage.data}"`
187183
);
188184
const receivedMessage = await _pullOneMessage(subscription);
189185
assert.strictEqual(receivedMessage.data.toString(), expectedMessage.data);

src/message-queues.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@ export class BatchError extends Error implements ServiceError {
5252
metadata?: Metadata;
5353
constructor(err: ServiceError, ackIds: string[], rpc: string) {
5454
super(
55-
`Failed to "${rpc}" for ${ackIds.length} message(s). Reason: ${
56-
err.message
57-
}`
55+
`Failed to "${rpc}" for ${ackIds.length} message(s). Reason: ${err.message}`
5856
);
5957

6058
this.ackIds = ackIds;

synth.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
# https://github.com/googleapis/gapic-generator/issues/2127
2525
s.replace("src/v1/subscriber_client.js",
26-
" }\n\s*/\*\*\n\s+\* The DNS address for this API service.",
26+
" }\n\s*/\*\*\n\s+\* The DNS address for this API service\.",
2727
"\n // note: editing generated code\n"
2828
" this.waitForReady = function(deadline, callback) {\n"
2929
" return subscriberStub.then(\n"

0 commit comments

Comments
 (0)