Skip to content

Commit 39b1dac

Browse files
yoshi-automationBenjamin E. Coe
yoshi-automation
authored and
Benjamin E. Coe
committed
fix: DEADLINE_EXCEEDED no longer treated as idempotent and retried
1 parent 22dc668 commit 39b1dac

File tree

5 files changed

+35
-18
lines changed

5 files changed

+35
-18
lines changed

‎src/v1/doc/google/type/doc_expr.js‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
// Copyright 2019 Google LLC
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// https://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS,
11+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
// See the License for the specific language governing permissions and
13+
// limitations under the License.
14+
15+
// Note: this file is purely for documentation. Any contents are not expected
16+
// to be loaded as the JS file.

‎src/v1/publisher_client.js‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -933,8 +933,7 @@ class PublisherClient {
933933
* The request object that will be sent.
934934
* @param {string} request.resource
935935
* REQUIRED: The resource for which the policy is being specified.
936-
* `resource` is usually specified as a path. For example, a Project
937-
* resource is specified as `projects/{project}`.
936+
* See the operation documentation for the appropriate value for this field.
938937
* @param {Object} request.policy
939938
* REQUIRED: The complete policy to be applied to the `resource`. The size of
940939
* the policy is limited to a few 10s of KB. An empty policy is a
@@ -1002,8 +1001,7 @@ class PublisherClient {
10021001
* The request object that will be sent.
10031002
* @param {string} request.resource
10041003
* REQUIRED: The resource for which the policy is being requested.
1005-
* `resource` is usually specified as a path. For example, a Project
1006-
* resource is specified as `projects/{project}`.
1004+
* See the operation documentation for the appropriate value for this field.
10071005
* @param {Object} [options]
10081006
* Optional parameters. You can override the default settings for this call, e.g, timeout,
10091007
* retries, paginations, etc. See [gax.CallOptions]{@link https://googleapis.github.io/gax-nodejs/global.html#CallOptions} for the details.
@@ -1055,12 +1053,15 @@ class PublisherClient {
10551053
* If the resource does not exist, this will return an empty set of
10561054
* permissions, not a NOT_FOUND error.
10571055
*
1056+
* Note: This operation is designed to be used for building permission-aware
1057+
* UIs and command-line tools, not for authorization checking. This operation
1058+
* may "fail open" without warning.
1059+
*
10581060
* @param {Object} request
10591061
* The request object that will be sent.
10601062
* @param {string} request.resource
10611063
* REQUIRED: The resource for which the policy detail is being requested.
1062-
* `resource` is usually specified as a path. For example, a Project
1063-
* resource is specified as `projects/{project}`.
1064+
* See the operation documentation for the appropriate value for this field.
10641065
* @param {string[]} request.permissions
10651066
* The set of permissions to check for the `resource`. Permissions with
10661067
* wildcards (such as '*' or 'storage.*') are not allowed. For more

‎src/v1/publisher_client_config.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
"publish": [
1515
"ABORTED",
1616
"CANCELLED",
17-
"DEADLINE_EXCEEDED",
1817
"INTERNAL",
1918
"RESOURCE_EXHAUSTED",
2019
"UNAVAILABLE",

‎src/v1/subscriber_client.js‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1543,8 +1543,7 @@ class SubscriberClient {
15431543
* The request object that will be sent.
15441544
* @param {string} request.resource
15451545
* REQUIRED: The resource for which the policy is being specified.
1546-
* `resource` is usually specified as a path. For example, a Project
1547-
* resource is specified as `projects/{project}`.
1546+
* See the operation documentation for the appropriate value for this field.
15481547
* @param {Object} request.policy
15491548
* REQUIRED: The complete policy to be applied to the `resource`. The size of
15501549
* the policy is limited to a few 10s of KB. An empty policy is a
@@ -1612,8 +1611,7 @@ class SubscriberClient {
16121611
* The request object that will be sent.
16131612
* @param {string} request.resource
16141613
* REQUIRED: The resource for which the policy is being requested.
1615-
* `resource` is usually specified as a path. For example, a Project
1616-
* resource is specified as `projects/{project}`.
1614+
* See the operation documentation for the appropriate value for this field.
16171615
* @param {Object} [options]
16181616
* Optional parameters. You can override the default settings for this call, e.g, timeout,
16191617
* retries, paginations, etc. See [gax.CallOptions]{@link https://googleapis.github.io/gax-nodejs/global.html#CallOptions} for the details.
@@ -1665,12 +1663,15 @@ class SubscriberClient {
16651663
* If the resource does not exist, this will return an empty set of
16661664
* permissions, not a NOT_FOUND error.
16671665
*
1666+
* Note: This operation is designed to be used for building permission-aware
1667+
* UIs and command-line tools, not for authorization checking. This operation
1668+
* may "fail open" without warning.
1669+
*
16681670
* @param {Object} request
16691671
* The request object that will be sent.
16701672
* @param {string} request.resource
16711673
* REQUIRED: The resource for which the policy detail is being requested.
1672-
* `resource` is usually specified as a path. For example, a Project
1673-
* resource is specified as `projects/{project}`.
1674+
* See the operation documentation for the appropriate value for this field.
16741675
* @param {string[]} request.permissions
16751676
* The set of permissions to check for the `resource`. Permissions with
16761677
* wildcards (such as '*' or 'storage.*') are not allowed. For more

‎synth.metadata‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
{
2-
"updateTime": "2019-05-04T11:20:08.592023Z",
2+
"updateTime": "2019-05-08T12:04:26.586274Z",
33
"sources": [
44
{
55
"generator": {
66
"name": "artman",
7-
"version": "0.18.0",
8-
"dockerImage": "googleapis/artman@sha256:29bd82cc42c43825fde408e63fc955f3f9d07ff9989243d7aa0f91a35c7884dc"
7+
"version": "0.19.0",
8+
"dockerImage": "googleapis/artman@sha256:d3df563538225ac6caac45d8ad86499500211d1bcb2536955a6dbda15e1b368e"
99
}
1010
},
1111
{
1212
"git": {
1313
"name": "googleapis",
1414
"remote": "https://github.com/googleapis/googleapis.git",
15-
"sha": "39c876cca5403e7e8282ce2229033cc3cc02962c",
16-
"internalRef": "246561601"
15+
"sha": "51145ff7812d2bb44c1219d0b76dac92a8bd94b2",
16+
"internalRef": "247143125"
1717
}
1818
},
1919
{

0 commit comments

Comments
 (0)