fix(subscription)!: decouple retainAckedMessages from messageRetentionDuration (#625)

callmehiphop · sduskis · commit 3431e7c102c8 · 2019-05-23T18:25:44.000-04:00
* fix(subscription)!: decouple retainAckedMessages from messageRetentionDuration

* remove system-test assertions
diff --git a/src/subscription.ts b/src/subscription.ts
@@ -1026,7 +1026,6 @@ export class Subscription extends EventEmitter {
     const formatted = extend(true, {}, metadata);
 
     if (typeof metadata.messageRetentionDuration === 'number') {
-      formatted.retainAckedMessages = true;
       (formatted as google.pubsub.v1.ISubscription).messageRetentionDuration = {
         seconds: metadata.messageRetentionDuration,
         nanos: 0,
diff --git a/system-test/pubsub.ts b/system-test/pubsub.ts
@@ -339,7 +339,6 @@ describe('pubsub', () => {
         sub!.getMetadata((err, metadata) => {
           assert.ifError(err);
 
-          assert.strictEqual(metadata!.retainAckedMessages, true);
           assert.strictEqual(
             Number(metadata!.messageRetentionDuration!.seconds),
             threeDaysInSeconds
@@ -371,7 +370,6 @@ describe('pubsub', () => {
         .then(([metadata]) => {
           const {seconds, nanos} = metadata.messageRetentionDuration!;
 
-          assert.strictEqual(metadata.retainAckedMessages, true);
           assert.strictEqual(Number(seconds), threeDaysInSeconds);
           assert.strictEqual(Number(nanos), 0);
         });
diff --git a/test/subscription.ts b/test/subscription.ts
@@ -227,7 +227,6 @@ describe('Subscription', () => {
 
       const formatted = Subscription.formatMetadata_(metadata);
 
-      assert.strictEqual(formatted.retainAckedMessages, true);
       assert.strictEqual(formatted.messageRetentionDuration!.nanos, 0);
 
       assert.strictEqual(
