This repository was archived by the owner on Dec 8, 2021. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 4 4
Lines 307 307
Branches 60 60
=======================================
Hits 283 283
Misses 15 15
Partials 9 9
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
May 10, 2019
Contributor
alexander-fenster
left a comment
There was a problem hiding this comment.
I'm totally approving my own changes here but would be great if someone else checked them as well :)
bcoe
reviewed
May 10, 2019
| assert.strictEqual( | ||
| createFromGoogleCredentialArg.args[0], | ||
| AUTH_CLIENT | ||
| grpcCredentials.constructor.name, |
There was a problem hiding this comment.
seems like this API surface here would be a breaking change? but is this breaking the law of demeter, mainly I don't think people using nodejs-common-grpc would have a reason to reach in here right?
bcoe
approved these changes
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: switches from
grpcto@grpc/grpc-js.@grpc/grpc-jsis a functionally equivalent pure-JS implementation, but does have some differences in its API surface. Also,@grpc/grpc-jsrequireshttp2support so only works in Node.js v8.9+.