fix: respect pageSize and pageToken from gaxOptions#781
Merged
bcoe merged 1 commit intogoogleapis:masterfrom Aug 7, 2020
Merged
fix: respect pageSize and pageToken from gaxOptions#781bcoe merged 1 commit intogoogleapis:masterfrom
bcoe merged 1 commit intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #781 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 17 17
Lines 15886 15944 +58
Branches 892 965 +73
=======================================
+ Hits 15750 15808 +58
Misses 133 133
Partials 3 3
Continue to review full report at Codecov.
|
bcoe
approved these changes
Aug 4, 2020
bcoe
left a comment
There was a problem hiding this comment.
I would lean towards calling this a fix:.
Even though this is technically a breaking change, I think given the prior behavior was obviously a bug, I'm comfortable landing as patch.
Would be curious if any other folks have thoughts though.
Contributor
Author
|
It shouldn't break an existing code, I believe. |
|
@AVaksman thank you 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
pageSizeandpageTokeningetTablesOptionspageSizeandpageTokenpassed fromgaxOptionsoptionstake precedence vs values fromgaxOptions