feat: Cloud functions example for Bigtable#728
Merged
billyjacobson merged 9 commits intomasterfrom May 11, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 15 15
Lines 15723 15723
Branches 888 955 +67
=======================================
Hits 15594 15594
Misses 126 126
Partials 3 3 Continue to review full report at Codecov.
|
Contributor
Author
|
question about npm run lint, on the CI tests it seems to be able to find the samples/functions directory, but when I run it locally it wasn't linting those files |
bcoe
suggested changes
May 11, 2020
bcoe
left a comment
There was a problem hiding this comment.
A few comments, having the nested functions/package.json is causing some issues for linting. If we don't actually reference this package.json on cloud.google.com, could we collapse the deps into samples/package.json?
# Conflicts: # samples/functions/index.js # samples/functions/package.json # samples/readSnippets.js
bcoe
approved these changes
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.