Skip to content

fix: clusterId issue in sample test(should list zones)#684

Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
laljikanjareeya:cluster-id-samples
Apr 2, 2020
Merged

fix: clusterId issue in sample test(should list zones)#684
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
laljikanjareeya:cluster-id-samples

Conversation

@laljikanjareeya
Copy link
Contributor

@laljikanjareeya laljikanjareeya commented Apr 2, 2020

Fixes #644 & #645

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2020
@JustinBeckwith JustinBeckwith merged commit b92dfc5 into googleapis:master Apr 2, 2020
yoshi-automation added a commit that referenced this pull request Apr 3, 2020
@yoshi-automation
fix: clusterId issue in sample test(should list zones) (#684)
3f4818d 
b92dfc5
commit b92dfc5
Author: Lalji Kanjareeya <46327204+laljikanjareeya@users.noreply.github.com>
Date:   Thu Apr 2 22:06:43 2020 +0530

    fix: clusterId issue in sample test(should list zones) (#684)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mocha Tests: should list zones failed

3 participants

@laljikanjareeya @JustinBeckwith @googlebot