Skip to content

fix: cluster id store as undefined in createInstance request#654

Merged
laljikanjareeya merged 6 commits intogoogleapis:masterfrom
laljikanjareeya:create-instance-cluster-issue
Mar 23, 2020
Merged

fix: cluster id store as undefined in createInstance request#654
laljikanjareeya merged 6 commits intogoogleapis:masterfrom
laljikanjareeya:create-instance-cluster-issue

Conversation

@laljikanjareeya
Copy link
Contributor

Fixes #652

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2020
@laljikanjareeya laljikanjareeya changed the title fix: cluster id store as undefined fix: cluster id store as undefined in createInstance request Mar 19, 2020
@JustinBeckwith JustinBeckwith added the needs work This is a pull request that needs a little love. label Mar 21, 2020
@laljikanjareeya laljikanjareeya removed the needs work This is a pull request that needs a little love. label Mar 23, 2020
@stephenplusplus
Copy link
Contributor

LGTM. Thank you!

@laljikanjareeya laljikanjareeya merged commit 809c719 into googleapis:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

id save as undefined if not provided in createInstance should throw an error

4 participants