Conversation
| const row = this.row!; | ||
| row.key = newRowKey; | ||
| row.data = {}; | ||
| this.family = row.data[chunk.familyName.value] = {} as Family; |
There was a problem hiding this comment.
am I dreaming, or am I really seeing the good old a = b = {} in the real-life JavaScript code? o_O
There was a problem hiding this comment.
Trying not to change the functionality here, but yeah....
There was a problem hiding this comment.
You know what, I'm taking this back! I just realized that it might be what they actually wanted to assign the same object to both this.family and row.data[chunk.familyName.value]. I'm afraid of this code :(
alexander-fenster
left a comment
There was a problem hiding this comment.
Possibly unintended logic change related to RegExp
Codecov Report
@@ Coverage Diff @@
## master #650 +/- ##
==========================================
+ Coverage 96.35% 96.38% +0.03%
==========================================
Files 15 15
Lines 12993 13118 +125
Branches 809 810 +1
==========================================
+ Hits 12519 12644 +125
Misses 471 471
Partials 3 3
Continue to review full report at Codecov.
|
|
@alexander-fenster ready for another look (this time with tests passing!) |
No description provided.