fix: improve typescript types for Table class#641
Merged
JustinBeckwith merged 2 commits intomasterfrom Mar 17, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
==========================================
+ Coverage 96.22% 96.31% +0.09%
==========================================
Files 15 15
Lines 12499 12819 +320
Branches 789 799 +10
==========================================
+ Hits 12027 12347 +320
Misses 469 469
Partials 3 3
Continue to review full report at Codecov.
|
|
|
||
| let Table: typeof tblTypes.Table; | ||
| let table: tblTypes.Table; | ||
| let table: any; |
Contributor
There was a problem hiding this comment.
don't we need eslint-ignore here? how does it work?
Contributor
Author
There was a problem hiding this comment.
Yikes, good call out. For some reason we don't... will fix this after we have user land types working properly (more important that tests)
alexander-fenster
approved these changes
Mar 17, 2020
Contributor
alexander-fenster
left a comment
There was a problem hiding this comment.
LGTM - but we'll need to do more work here getting rid of proto/ folder.
Contributor
|
LGTM thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incrementally inching towards #635. This ensures proper types in
table.ts.