feat: add support of customTimeBefore and daysSinceCustomTime#396
feat: add support of customTimeBefore and daysSinceCustomTime#396frankyn merged 5 commits intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #396 +/- ##
============================================
+ Coverage 64.49% 64.52% +0.02%
+ Complexity 623 614 -9
============================================
Files 32 32
Lines 5199 5220 +21
Branches 501 505 +4
============================================
+ Hits 3353 3368 +15
- Misses 1687 1693 +6
Partials 159 159
Continue to review full report at Codecov.
|
frankyn
left a comment
There was a problem hiding this comment.
Hi @athakor,
Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.
Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest
This has been updated in the latest release dependency in PR (#457). Please update relevant documentation.
frankyn
left a comment
There was a problem hiding this comment.
Hi @athakor,
Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.
Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest
This has been updated in the latest release dependency in PR (#457). Please update relevant documentation.
@frankyn That change has been already done also updated the relevant java doc. |
|
@jkwlui @JesseLovelace PTAL |
| return matchesStorageClass; | ||
| } | ||
|
|
||
| /* Returns the date in RFC 3339 format with only the date part (for instance, "2013-01-15")*/ |
There was a problem hiding this comment.
End this with a period, i.e. "(for instance, "2013-01-15"). */"
Towards #395