Skip to content

Conversation

@olavloite
Copy link
Collaborator

Compiled client side statements should be immutable as they are only imported and compiled once.

@olavloite olavloite added the type: cleanup An internal cleanup or hygiene concern. label Feb 1, 2021
@olavloite olavloite requested a review from a team as a code owner February 1, 2021 13:37
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Feb 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #843 (b857ff5) into master (61ea2b9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #843   +/-   ##
=========================================
  Coverage     85.04%   85.04%           
+ Complexity     2585     2583    -2     
=========================================
  Files           143      143           
  Lines         14145    14146    +1     
  Branches       1369     1369           
=========================================
+ Hits          12030    12031    +1     
  Misses         1542     1542           
  Partials        573      573           
Impacted Files Coverage Δ Complexity Δ
...ud/spanner/connection/ClientSideStatementImpl.java 50.00% <100.00%> (+1.11%) 9.00 <0.00> (ø)
...connection/ClientSideStatementNoParamExecutor.java 71.42% <100.00%> (ø) 2.00 <1.00> (-1.00)
...ner/connection/ClientSideStatementSetExecutor.java 85.36% <100.00%> (ø) 5.00 <1.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ea2b9...be7cdfd. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 118d1b3 into master Feb 2, 2021
@thiagotnunes thiagotnunes deleted the statements-immutable branch February 2, 2021 03:28
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#6288

Changes:

feat: Update minimum Ruby version to 2.6
  PiperOrigin-RevId: 458023995
  Source-Link: googleapis/googleapis@d1c0171

fix: Revert Enable REST transport for Cloud Bigtable
  PiperOrigin-RevId: 458022604
  Source-Link: googleapis/googleapis@e5507fc

chore: regenerate API index

  Source-Link: googleapis/googleapis@98698f5

feat: add options for library generation in C#, PHP and Ruby docs: clarify possible transaction types and API type enum values in several APIs
  PiperOrigin-RevId: 458016835
  Source-Link: googleapis/googleapis@203c38e

docs(dataflow): corrected the Dataflow job name regex
  PiperOrigin-RevId: 458015583
  Source-Link: googleapis/googleapis@9b7d76e

docs(dialogflow/cx): clarify descriptions of the AdvancedSettings and WebhookRequest data types
  PiperOrigin-RevId: 458000126
  Source-Link: googleapis/googleapis@c425ac6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants