Skip to content

feat: Add ComputeHeadCursor RPC for Pub/Sub Lite #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jiangmichaellll merged 2 commits into from
Dec 16, 2020
Merged

feat: Add ComputeHeadCursor RPC for Pub/Sub Lite #429

jiangmichaellll merged 2 commits into from
Dec 16, 2020

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Dec 15, 2020

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/81373600-1050-4fe2-a366-8c11d8ad5bc2/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 347681363
Source-Link: googleapis/googleapis@f967ea0

@yoshi-automation
feat: Add ComputeHeadCursor RPC for Pub/Sub Lite.
ee767a9 
PiperOrigin-RevId: 347681363

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Dec 15 13:31:04 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: f967ea0c0437a269515665ff9dbb69fcf134ddd9
Source-Link: googleapis/googleapis@f967ea0
@yoshi-automation yoshi-automation requested review from a team as code owners December 15, 2020 23:18
@generated-files-bot
Copy link

generated-files-bot bot commented Dec 15, 2020

Warning: This pull request is touching the following templated files:

  • google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/v1/TopicStatsServiceClient.java
  • google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/v1/TopicStatsServiceSettings.java
  • google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/v1/stub/GrpcTopicStatsServiceStub.java
  • google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/v1/stub/TopicStatsServiceStub.java
  • google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/v1/stub/TopicStatsServiceStubSettings.java
  • google-cloud-pubsublite/src/test/java/com/google/cloud/pubsublite/v1/MockTopicStatsServiceImpl.java
  • google-cloud-pubsublite/src/test/java/com/google/cloud/pubsublite/v1/TopicStatsServiceClientTest.java
  • grpc-google-cloud-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/TopicStatsServiceGrpc.java
  • proto-google-cloud-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/ComputeMessageStatsResponse.java
  • proto-google-cloud-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/ComputeMessageStatsResponseOrBuilder.java
  • proto-google-cloud-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/CreateSubscriptionRequest.java
  • proto-google-cloud-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/CreateSubscriptionRequestOrBuilder.java
  • proto-google-cloud-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/CreateTopicRequest.java
  • proto-google-cloud-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/CreateTopicRequestOrBuilder.java
  • proto-google-cloud-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/PublisherProto.java
  • proto-google-cloud-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/SubscriberProto.java
  • proto-google-cloud-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/TopicStatsProto.java
  • proto-google-cloud-pubsublite-v1/src/main/proto/google/cloud/pubsublite/v1/admin.proto
  • proto-google-cloud-pubsublite-v1/src/main/proto/google/cloud/pubsublite/v1/common.proto
  • proto-google-cloud-pubsublite-v1/src/main/proto/google/cloud/pubsublite/v1/cursor.proto
  • proto-google-cloud-pubsublite-v1/src/main/proto/google/cloud/pubsublite/v1/publisher.proto
  • proto-google-cloud-pubsublite-v1/src/main/proto/google/cloud/pubsublite/v1/subscriber.proto
  • proto-google-cloud-pubsublite-v1/src/main/proto/google/cloud/pubsublite/v1/topic_stats.proto

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2020
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 15, 2020
@codecov
Copy link

codecov bot commented Dec 15, 2020 •
edited
Loading

Codecov Report

Merging #429 (ee767a9) into master (86aecc9) will increase coverage by 0.72%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #429      +/-   ##
============================================
+ Coverage     71.01%   71.74%   +0.72%     
+ Complexity      898      881      -17     
============================================
  Files           167      164       -3     
  Lines          4733     4650      -83     
  Branches        240      233       -7     
============================================
- Hits           3361     3336      -25     
+ Misses         1234     1183      -51     
+ Partials        138      131       -7
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsublite/v1/TopicStatsServiceSettings.java 22.58% <0.00%> (-1.56%) 2.00 <0.00> (ø)
...loud/pubsublite/v1/stub/TopicStatsServiceStub.java 33.33% <0.00%> (-16.67%) 1.00 <0.00> (ø)
...sublite/v1/stub/TopicStatsServiceStubSettings.java 78.40% <85.71%> (+2.09%) 11.00 <1.00> (+1.00)
...e/cloud/pubsublite/v1/TopicStatsServiceClient.java 69.23% <100.00%> (+2.56%) 10.00 <2.00> (+2.00)
.../pubsublite/v1/stub/GrpcTopicStatsServiceStub.java 84.37% <100.00%> (+7.10%) 8.00 <1.00> (+1.00)
...m/google/cloud/pubsublite/spark/PslDataSource.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...e/cloud/pubsublite/spark/SparkPartitionOffset.java 100.00% <0.00%> (ø) 2.00% <0.00%> (-1.00%)
...le/cloud/pubsublite/spark/PslMicroBatchReader.java
...blite/spark/PslMicroBatchInputPartitionReader.java
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86aecc9...754afd0. Read the comment docs.

@dpcollins-google dpcollins-google changed the title feat: Add ComputeHeadCursor RPC for Pub/Sub Lite. feat: Add ComputeHeadCursor RPC for Pub/Sub Lite Dec 16, 2020
@jiangmichaellll jiangmichaellll merged commit 34d8d02 into master Dec 16, 2020
@jiangmichaellll jiangmichaellll deleted the autosynth-googleapis branch December 16, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jiangmichaellll jiangmichaellll jiangmichaellll approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement. context: full

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshi-automation @jiangmichaellll @dpcollins-google