Skip to content

feat: Use the partition watching publisher in the cps client #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
palmere-google merged 2 commits into from
Dec 10, 2020
Merged

feat: Use the partition watching publisher in the cps client #409

palmere-google merged 2 commits into from
Dec 10, 2020

Conversation

@palmere-google
Copy link
Contributor

@palmere-google palmere-google commented Dec 8, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@palmere-google palmere-google requested a review from a team as a code owner December 8, 2020 07:38
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 8, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 8, 2020
@palmere-google palmere-google marked this pull request as draft December 8, 2020 07:39
@palmere-google palmere-google force-pushed the palmere-increase3 branch 2 times, most recently from e04736a to 4a68c5a Compare December 8, 2020 07:41
@palmere-google palmere-google marked this pull request as ready for review December 8, 2020 07:46
@palmere-google palmere-google changed the title Use the partition watching publisher in the cps client feat: Use the partition watching publisher in the cps client Dec 8, 2020
@codecov
Copy link

codecov bot commented Dec 8, 2020 •
edited
Loading

Codecov Report

Merging #409 (83ab80c) into master (0e4cb93) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #409      +/-   ##
============================================
- Coverage     71.70%   71.68%   -0.03%     
- Complexity      814      840      +26     
============================================
  Files           156      158       +2     
  Lines          4404     4400       -4     
  Branches        219      223       +4     
============================================
- Hits           3158     3154       -4     
+ Misses         1126     1125       -1     
- Partials        120      121       +1
Impacted Files Coverage Δ Complexity Δ
...loud/pubsublite/internal/wire/RoutingMetadata.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...google/cloud/pubsublite/beam/PublisherOptions.java 25.00% <0.00%> (+1.47%) 4.00 <0.00> (ø)
...loud/pubsublite/cloudpubsub/PublisherSettings.java 68.75% <83.33%> (-31.25%) 5.00 <0.00> (-2.00)
...oud/pubsublite/cloudpubsub/SubscriberSettings.java 89.36% <100.00%> (-0.23%) 12.00 <0.00> (ø)
...gle/cloud/pubsublite/internal/AdminClientImpl.java 100.00% <100.00%> (ø) 18.00 <2.00> (ø)
...loud/pubsublite/internal/TopicStatsClientImpl.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...loud/pubsublite/internal/wire/AssignerBuilder.java 65.38% <100.00%> (-1.29%) 3.00 <0.00> (ø)
...oud/pubsublite/internal/wire/CommitterBuilder.java 52.63% <100.00%> (-2.37%) 2.00 <0.00> (ø)
...oud/pubsublite/internal/wire/PublisherBuilder.java 62.26% <100.00%> (ø) 3.00 <0.00> (ø)
...ud/pubsublite/internal/wire/SubscriberBuilder.java 40.74% <100.00%> (-2.12%) 2.00 <0.00> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 509dad6...83ab80c. Read the comment docs.

@palmere-google palmere-google merged commit b85ceb4 into master Dec 10, 2020
@palmere-google palmere-google deleted the palmere-increase3 branch December 10, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpcollins-google dpcollins-google dpcollins-google approved these changes

Assignees

@dpcollins-google dpcollins-google

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@palmere-google @dpcollins-google