feat: Separates Offsets from different context (Spark vs PSL) #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
============================================
+ Coverage 71.85% 71.95% +0.09%
- Complexity 828 833 +5
============================================
Files 156 158 +2
Lines 4356 4457 +101
Branches 221 223 +2
============================================
+ Hits 3130 3207 +77
- Misses 1106 1125 +19
- Partials 120 125 +5 Continue to review full report at Codecov.
|
jiangmichaellll
commented
Dec 4, 2020
...e-spark-sql-streaming/src/main/java/com/google/cloud/pubsublite/spark/SparkSourceOffset.java
Show resolved
Hide resolved
...ite-spark-sql-streaming/src/main/java/com/google/cloud/pubsublite/spark/PslSourceOffset.java
Outdated
Show resolved
Hide resolved
...e-spark-sql-streaming/src/main/java/com/google/cloud/pubsublite/spark/SparkSourceOffset.java
Show resolved
Hide resolved
Collaborator
|
LGTM other than don't write your own equals or hashcode methods. Ping me when you've fixed that issue |
dpcollins-google
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark offset means msgs with offsets less than or equal to have been processed, and next to be delivered is spark_offset+1.
PSL offset means msgs with offsets less than have been processed, and next to be delivered is psl_offset.
Spark side:
SparkSourceOffset, SparkPartitionOffset
PSL side:
PslSourceOffset, PslPartitionOffset
Also added utils method to convert between PSL and Spark.