Skip to content

feat: Implement PubsubLiteProducer #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpcollins-google merged 2 commits into from
Oct 8, 2020
Merged

feat: Implement PubsubLiteProducer #280

dpcollins-google merged 2 commits into from
Oct 8, 2020

Conversation

@dpcollins-google
Copy link
Collaborator

@dpcollins-google dpcollins-google commented Oct 5, 2020

feat: Implement PubsubLiteProducer

@dpcollins-google dpcollins-google requested a review from a team as a code owner October 5, 2020 15:10
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #280 into master will decrease coverage by 0.04%.
The diff coverage is 67.08%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #280      +/-   ##
============================================
- Coverage     70.99%   70.94%   -0.05%     
- Complexity      784      801      +17     
============================================
  Files           146      148       +2     
  Lines          4254     4333      +79     
  Branches        217      219       +2     
============================================
+ Hits           3020     3074      +54     
- Misses         1107     1132      +25     
  Partials        127      127
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/pubsublite/kafka/ProducerSettings.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...gle/cloud/pubsublite/kafka/PubsubLiteProducer.java 77.94% <77.94%> (ø) 16.00 <16.00> (?)
...oogle/cloud/pubsublite/kafka/RecordTransforms.java 88.46% <0.00%> (+3.84%) 4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b42da5f...634912c. Read the comment docs.

@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Oct 6, 2020
@dpcollins-google dpcollins-google merged commit 1879470 into master Oct 8, 2020
@dpcollins-google dpcollins-google deleted the producer-impl branch October 8, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelmenzella-google manuelmenzella-google manuelmenzella-google approved these changes

Assignees

No one assigned

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpcollins-google @manuelmenzella-google