Skip to content

Conversation

@dpcollins-google
Copy link
Collaborator

This will be used by the kafka shim.

@dpcollins-google dpcollins-google requested a review from a team as a code owner September 24, 2020 14:02
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2020
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #252 into master will increase coverage by 0.05%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #252      +/-   ##
============================================
+ Coverage     72.74%   72.80%   +0.05%     
- Complexity      759      773      +14     
============================================
  Files           135      138       +3     
  Lines          4033     4085      +52     
  Branches        213      213              
============================================
+ Hits           2934     2974      +40     
- Misses          975      986      +11     
- Partials        124      125       +1     
Impacted Files Coverage Δ Complexity Δ
...google/cloud/pubsublite/internal/CursorClient.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...loud/pubsublite/internal/CursorClientSettings.java 75.00% <75.00%> (ø) 3.00 <3.00> (?)
...le/cloud/pubsublite/internal/CursorClientImpl.java 79.06% <79.06%> (ø) 10.00 <10.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4111f09...81c319d. Read the comment docs.

@dpcollins-google dpcollins-google merged commit eabe900 into master Sep 24, 2020
@dpcollins-google dpcollins-google deleted the cursor_client branch September 24, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants