Skip to content

fix: Assorted warnings. #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpcollins-google merged 1 commit into from
Sep 15, 2020
Merged

fix: Assorted warnings. #246

dpcollins-google merged 1 commit into from
Sep 15, 2020

Conversation

@dpcollins-google
Copy link
Collaborator

@dpcollins-google dpcollins-google commented Sep 15, 2020

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2020
@codecov
Copy link

codecov bot commented Sep 15, 2020 •
edited
Loading

Codecov Report

Merging #246 into master will decrease coverage by 0.05%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #246      +/-   ##
============================================
- Coverage     72.96%   72.91%   -0.06%     
  Complexity      755      755              
============================================
  Files           135      135              
  Lines          3995     3995              
  Branches        211      211              
============================================
- Hits           2915     2913       -2     
- Misses          956      958       +2     
  Partials        124      124
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/pubsublite/ProjectLookupUtils.java 21.42% <33.33%> (-9.35%) 4.00 <3.00> (ø)
...gle/cloud/pubsublite/internal/AdminClientImpl.java 88.88% <83.33%> (-0.11%) 24.00 <1.00> (ø)
...loud/pubsublite/internal/TopicStatsClientImpl.java 70.00% <100.00%> (ø) 7.00 <0.00> (ø)
...loud/pubsublite/internal/wire/AssignerBuilder.java 82.60% <100.00%> (ø) 3.00 <0.00> (ø)
...oud/pubsublite/internal/wire/CommitterBuilder.java 73.33% <100.00%> (ø) 2.00 <0.00> (ø)
...oud/pubsublite/internal/wire/PublisherBuilder.java 86.36% <100.00%> (ø) 3.00 <0.00> (ø)
...loud/pubsublite/internal/wire/RoutingMetadata.java 81.81% <100.00%> (ø) 3.00 <0.00> (ø)
...ud/pubsublite/internal/wire/SubscriberBuilder.java 78.94% <100.00%> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7deb610...751750f. Read the comment docs.

@dpcollins-google dpcollins-google merged commit a65da39 into master Sep 15, 2020
@dpcollins-google dpcollins-google deleted the fix-check-return-value branch September 15, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hannahrogers-google hannahrogers-google hannahrogers-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpcollins-google @hannahrogers-google