feat: adding support for dead letter queues #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
========================================
Coverage 78.9% 78.9%
Complexity 290 290
========================================
Files 21 21
Lines 2583 2583
Branches 128 128
========================================
Hits 2038 2038
Misses 490 490
Partials 55 55Continue to review full report at Codecov.
|
maheshgattani
left a comment
There was a problem hiding this comment.
Looking good. Left a couple of comments.
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java
Show resolved
Hide resolved
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Subscriber.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Completes Feature Request #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.