Skip to content

fix: adding deprecated tags to deprecated methods #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elharo merged 45 commits into from
Jan 21, 2021
Merged

fix: adding deprecated tags to deprecated methods #472

elharo merged 45 commits into from
Jan 21, 2021

Conversation

@hannahrogers-google
Copy link
Contributor

@hannahrogers-google hannahrogers-google commented Dec 23, 2020

Fixes #249 ☕️

@hannahrogers-google
Modifying Publish example in README to match other examples given, and
19dd129 
fix issue #6784
@hannahrogers-google
fix: Modifying Publish example in README to match other examples, and
4158529 
fix Issue googleapis#11
@hannahrogers-google
Merge branch 'master' of github.com:hannahrogers-google/java-pubsub
7d704f0
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
9e0ebc6
@hannahrogers-google
feat: Adding support for DLQs
01d41b7 
Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@hannahrogers-google
Fix formatting
ed3b1ee
@hannahrogers-google
fix: making changes requested in pull request
72f7996
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
389cb86
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
c9e4bd2
@hannahrogers-google
fix: creating fix to not populate delivery attempt attribute when dead
3738ec8 
lettering is not enabled
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
4ce1d3b
@hannahrogers-google
Adding unit test for case in which a received message has no delivery…
aecd4ca 
… attempt
@hannahrogers-google
Making MessageWaiter class more generic to also be used for outstanding
77fa3b3 
ack operations
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
b87023c
@hannahrogers-google
Merge branch 'master' into fix-subscriber-stop
7086b3c
@hannahrogers-google
Waiting for acks to complete before shutting down a streaming subscriber
da0e355 
connection
@hannahrogers-google
Fixing formatting error
dc55fc1
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
45beee2
@hannahrogers-google
fix: making sure all publishes complete before shutting down the
548b7a7 
publisher
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
76a1de9
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
a8989f1
@hannahrogers-google
adding default max outstanding request bytes
b4439fd
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
01f607c
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
c0cddb3
@hannahrogers-google
fix: make push endpoint valid https
9a6381d
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
0bd165f
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
5d47be8
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub in…
e3b7f6d 
…to master
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub in…
6c1a26c 
…to master
@hannahrogers-google
fix: use default zero value if a flow control setting is not provided
f2fa6b8
@hannahrogers-google hannahrogers-google requested review from a team as code owners December 23, 2020 20:15
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Dec 23, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 23, 2020
@codecov
Copy link

codecov bot commented Dec 23, 2020 •
edited
Loading

Codecov Report

Merging #472 (9ac49ea) into master (260eca5) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #472      +/-   ##
============================================
- Coverage     79.17%   79.14%   -0.04%     
  Complexity      323      323              
============================================
  Files            21       21              
  Lines          2925     2925              
  Branches        166      166              
============================================
- Hits           2316     2315       -1     
  Misses          541      541              
- Partials         68       69       +1
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 84.87% <0.00%> (-0.49%) 26.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260eca5...9ac49ea. Read the comment docs.

@hannahrogers-google hannahrogers-google requested a review from a team January 6, 2021 21:59
@stephaniewang526 stephaniewang526 requested review from chingor13 and removed request for stephaniewang526 January 21, 2021 18:47
@elharo elharo merged commit 91b5152 into googleapis:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 Awaiting requested review from chingor13

1 more reviewer

@elharo elharo elharo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use @Deprecated tag in TopicAdminClient and SubscriptionAdminClient

2 participants

@hannahrogers-google @elharo