fix: Only check keyHasError if ordering key is non-empty #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9c113c3.
…ed when publishing.
… key are canceled when a previous publish for the ordering keys fails.
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
=========================================
Coverage 79.20% 79.20%
- Complexity 319 320 +1
=========================================
Files 21 21
Lines 2905 2905
Branches 159 159
=========================================
Hits 2301 2301
Misses 537 537
Partials 67 67
Continue to review full report at Codecov.
|
hannahrogers-google
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.