Skip to content

Conversation

@vinnyspb
Copy link
Contributor

@vinnyspb vinnyspb commented Jul 24, 2020

HeaderProvider is missing from PublisherStubSettings initialisation

@google-cla
Copy link

google-cla bot commented Jul 24, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 24, 2020
@google-cla
Copy link

google-cla bot commented Jul 24, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #294 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #294      +/-   ##
============================================
+ Coverage     79.18%   79.23%   +0.04%     
  Complexity      317      317              
============================================
  Files            21       21              
  Lines          2888     2889       +1     
  Branches        155      155              
============================================
+ Hits           2287     2289       +2     
  Misses          537      537              
+ Partials         64       63       -1     
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 88.00% <100.00%> (+0.03%) 46.00 <0.00> (ø)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.36% <0.00%> (+0.48%) 26.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f981b...f76b07f. Read the comment docs.

@vinnyspb vinnyspb marked this pull request as draft July 24, 2020 13:02
@davidxia
Copy link

Nice catch! I think you'll need to sign the contribute license agreement (CLA).

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 24, 2020
@vinnyspb vinnyspb marked this pull request as ready for review July 24, 2020 15:27
@hannahrogers-google hannahrogers-google self-requested a review July 24, 2020 20:49
@hannahrogers-google hannahrogers-google self-assigned this Jul 24, 2020
@hannahrogers-google hannahrogers-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2020
@hannahrogers-google hannahrogers-google merged commit 6bd5016 into googleapis:master Jul 24, 2020
@vinnyspb vinnyspb deleted the patch-1 branch July 27, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants