Skip to content

feat(deps): adopt flatten plugin and google-cloud-shared-dependencies #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephaniewang526 merged 1 commit into from
Jun 22, 2020
Merged

feat(deps): adopt flatten plugin and google-cloud-shared-dependencies #259

stephaniewang526 merged 1 commit into from
Jun 22, 2020

Conversation

@yangnuoyu
Copy link
Contributor

@yangnuoyu yangnuoyu commented Jun 18, 2020 •
edited
Loading

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a5f45ac). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #259   +/-   ##
=========================================
  Coverage          ?   79.17%           
  Complexity        ?      316           
=========================================
  Files             ?       21           
  Lines             ?     2877           
  Branches          ?      153           
=========================================
  Hits              ?     2278           
  Misses            ?      537           
  Partials          ?       62
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/pubsub/v1/SubscriptionAdminClient.java 63.06% <0.00%> (ø) 52.00% <0.00%> (?%)
...com/google/cloud/pubsub/v1/stub/PublisherStub.java 6.25% <0.00%> (ø) 1.00% <0.00%> (?%)
.../pubsub/v1/stub/GrpcSubscriberCallableFactory.java 50.00% <0.00%> (ø) 4.00% <0.00%> (?%)
...c/main/java/com/google/cloud/pubsub/v1/Waiter.java 76.47% <0.00%> (ø) 6.00% <0.00%> (?%)
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 87.96% <0.00%> (ø) 46.00% <0.00%> (?%)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.14% <0.00%> (ø) 25.00% <0.00%> (?%)
...e/cloud/pubsub/v1/stub/SubscriberStubSettings.java 85.32% <0.00%> (ø) 28.00% <0.00%> (?%)
...oogle/cloud/pubsub/v1/stub/GrpcSubscriberStub.java 97.90% <0.00%> (ø) 26.00% <0.00%> (?%)
...in/java/com/google/cloud/pubsub/v1/StatusUtil.java 71.42% <0.00%> (ø) 4.00% <0.00%> (?%)
...gle/cloud/pubsub/v1/SubscriptionAdminSettings.java 13.84% <0.00%> (ø) 4.00% <0.00%> (?%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f45ac...2a21b1f. Read the comment docs.

@yangnuoyu yangnuoyu marked this pull request as ready for review June 22, 2020 15:44
@stephaniewang526 stephaniewang526 self-requested a review June 22, 2020 15:46
@stephaniewang526 stephaniewang526 merged commit 6b0947b into googleapis:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yangnuoyu @stephaniewang526 @googlebot