feat: implement max duration per ack extension #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.
lettering is not enabled
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
============================================
- Coverage 79.05% 79.04% -0.02%
- Complexity 312 313 +1
============================================
Files 21 21
Lines 2841 2849 +8
Branches 153 155 +2
============================================
+ Hits 2246 2252 +6
Misses 533 533
- Partials 62 64 +2
Continue to review full report at Codecov.
|
kamalaboulhosn
requested changes
May 27, 2020
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@kamalaboulhosn, friendly ping - can you take another look at this? |
Contributor
|
Apologies, this wasn't showing up in my list of pending reviews. |
kamalaboulhosn
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93