This repository was archived by the owner on Feb 6, 2026. It is now read-only.
feat: Add destination property into LogEntry#720
Merged
Merged
Conversation
…me customization and integrate it with LogEntry
minherz
suggested changes
Oct 21, 2021
minherz
suggested changes
Oct 22, 2021
minherz
left a comment
Contributor
There was a problem hiding this comment.
Please, address a case when the log name destination is lost when parsing it from protobuf.
The code in unit test should be aligned with Java guidelines (constants naming convention and multiple use of the same string literals).
Also consider other non-blocking comments.
minherz
approved these changes
Oct 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ResourceName which will provide destination log resource name customization for LogEntry
Fixes #719 ☕️