Skip to content

fix: bom version tag misconfigured #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BenWhitehead merged 1 commit into from
Feb 13, 2020
Merged

fix: bom version tag misconfigured #42

BenWhitehead merged 1 commit into from
Feb 13, 2020

Conversation

@BenWhitehead
Copy link
Collaborator

@BenWhitehead BenWhitehead commented Feb 13, 2020

The bom had been miss configured to change the version of google-cloud-datastore to be the version for proto-google-cloud-datastore-v1 this change fixes the marker and the version.

@BenWhitehead
fix: bom version tag miss configured
f0e77c7 
The bom had been miss configured to change the version of google-cloud-datastore to be the version for proto-google-cloud-datastore-v1 this change fixes the marker and the version.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2020
@BenWhitehead BenWhitehead requested a review from a team February 13, 2020 18:35
@codecov
Copy link

codecov bot commented Feb 13, 2020 •
edited
Loading

Codecov Report

Merging #42 into master will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #42      +/-   ##
============================================
+ Coverage     59.44%   59.72%   +0.27%     
+ Complexity      384      378       -6     
============================================
  Files            46       46              
  Lines          2286     2262      -24     
  Branches        251      247       -4     
============================================
- Hits           1359     1351       -8     
+ Misses          820      804      -16     
  Partials        107      107
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/datastore/PathElement.java 79.06% <0%> (-0.48%) 23% <0%> (-3%)
.../src/main/java/com/google/cloud/datastore/Key.java 79.1% <0%> (-0.31%) 16% <0%> (ø)
...java/com/google/cloud/datastore/IncompleteKey.java 87.8% <0%> (-0.3%) 9% <0%> (ø)
.../main/java/com/google/cloud/datastore/BaseKey.java 89.39% <0%> (-0.16%) 14% <0%> (ø)
...va/com/google/cloud/datastore/StructuredQuery.java 71.38% <0%> (-0.08%) 23% <0%> (ø)
...java/com/google/cloud/datastore/DatastoreImpl.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...a/com/google/cloud/datastore/QueryResultsImpl.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/com/google/cloud/datastore/KeyFactory.java 100% <0%> (ø) 7% <0%> (-3%) ⬇️
...ain/java/com/google/cloud/datastore/BatchImpl.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...va/com/google/cloud/datastore/TransactionImpl.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a846723...f0e77c7. Read the comment docs.

@BenWhitehead BenWhitehead merged commit 6af084f into googleapis:master Feb 13, 2020
@BenWhitehead BenWhitehead deleted the bom-version-fix branch February 13, 2020 18:43
@elharo elharo changed the title fix: bom version tag miss configured fix: bom version tag misconfigured Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BenWhitehead @chingor13 @googlebot