Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

fix: An extra test that is still calling old JsonStreamWriter append#760

Merged
stephaniewang526 merged 2 commits intogoogleapis:masterfrom
yirutang:fix
Jan 5, 2021
Merged

fix: An extra test that is still calling old JsonStreamWriter append#760
stephaniewang526 merged 2 commits intogoogleapis:masterfrom
yirutang:fix

Conversation

@yirutang
Copy link
Copy Markdown
Contributor

@yirutang yirutang commented Jan 5, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from a team and chingor13 January 5, 2021 18:12
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 5, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Jan 5, 2021
@yirutang yirutang changed the title fix:an extra test that is still calling old JsonStreamWriter append fix: An extra test that is still calling old JsonStreamWriter append Jan 5, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 5, 2021 •
edited
Loading

Codecov Report

Merging #760 (5868a3a) into master (0988105) will increase coverage by 0.01%.
The diff coverage is 82.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #760      +/-   ##
============================================
+ Coverage     80.84%   80.85%   +0.01%     
- Complexity      983      992       +9     
============================================
  Files            73       74       +1     
  Lines          5283     5333      +50     
  Branches        404      412       +8     
============================================
+ Hits           4271     4312      +41     
- Misses          843      848       +5     
- Partials        169      173       +4
Impacted Files Coverage Δ Complexity Δ
...oud/bigquery/storage/v1beta2/JsonStreamWriter.java 78.99% <79.16%> (+1.11%) 15.00 <2.00> (+2.00)
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 85.01% <82.60%> (-0.08%) 38.00 <2.00> (+1.00) ⬇️
...uery/storage/v1beta2/BQV2ToBQStorageConverter.java 84.84% <84.84%> (ø) 6.00 <6.00> (?)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 83.87% <0.00%> (-0.44%) 37.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488f258...5868a3a. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit af72e6e into googleapis:master Jan 5, 2021
@stephaniewang526 stephaniewang526 mentioned this pull request Jan 5, 2021
Closed
1 task
@yirutang yirutang deleted the fix branch February 18, 2021 00:10
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-storage to v2.2…
33fffbf 
….1 (googleapis#760)
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@release-please
chore: release 0.123.17 (googleapis#751)
0a5f475 
🤖 I have created a release \*beep\* \*boop\*
---
### [0.123.17](https://www.github.com/googleapis/java-storage-nio/compare/v0.123.16...v0.123.17) (2021-12-06)


### Bug Fixes

* **java:** java 17 dependency arguments ([googleapis#1266](https://www.github.com/googleapis/java-storage-nio/issues/1266)) ([googleapis#750](https://www.github.com/googleapis/java-storage-nio/issues/750)) ([3f866da](https://www.github.com/googleapis/java-storage-nio/commit/3f866da0aa3b381477c883b4f11239640c577d88))


### Dependencies

* update dependency com.google.apis:google-api-services-storage to v1-rev20211018-1.32.1 ([googleapis#749](https://www.github.com/googleapis/java-storage-nio/issues/749)) ([7e99920](https://www.github.com/googleapis/java-storage-nio/commit/7e99920cfeef90ad5af5503a63338c48a57cb674))
* update dependency com.google.apis:google-api-services-storage to v1-rev20211201-1.32.1 ([googleapis#768](https://www.github.com/googleapis/java-storage-nio/issues/768)) ([650d9b5](https://www.github.com/googleapis/java-storage-nio/commit/650d9b5d76869f31d0456f9f3a9c01c9e9ae6ef9))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.0 ([googleapis#759](https://www.github.com/googleapis/java-storage-nio/issues/759)) ([7cb3292](https://www.github.com/googleapis/java-storage-nio/commit/7cb32926da5f910e3636d12a1ad412b4e3531b05))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.1 ([googleapis#767](https://www.github.com/googleapis/java-storage-nio/issues/767)) ([7eb3dfa](https://www.github.com/googleapis/java-storage-nio/commit/7eb3dfab9644f48f0063fb1be4f9805062b2eae8))
* update dependency com.google.cloud:google-cloud-storage to v2.2.0 ([googleapis#753](https://www.github.com/googleapis/java-storage-nio/issues/753)) ([fcbc986](https://www.github.com/googleapis/java-storage-nio/commit/fcbc986c020ab48412218ab3825c2423a90d70d4))
* update dependency com.google.cloud:google-cloud-storage to v2.2.1 ([googleapis#760](https://www.github.com/googleapis/java-storage-nio/issues/760)) ([33fffbf](https://www.github.com/googleapis/java-storage-nio/commit/33fffbf3d79335b36e78af95e0f26cb9ec5f5f4e))
* update dependency com.google.cloud:google-cloud-storage to v2.2.2 ([googleapis#769](https://www.github.com/googleapis/java-storage-nio/issues/769)) ([4f48a96](https://www.github.com/googleapis/java-storage-nio/commit/4f48a96feb32a43c590a286d8c622b2ba845b8f2))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chingor13 chingor13 Awaiting requested review from chingor13

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yirutang @stephaniewang526