This repository was archived by the owner on Mar 23, 2026. It is now read-only.
feat: support authorized UDF entries in dataset ACL#875
Merged
stephaniewang526 merged 1 commit intogoogleapis:masterfrom Oct 27, 2020
Merged
feat: support authorized UDF entries in dataset ACL#875stephaniewang526 merged 1 commit intogoogleapis:masterfrom
stephaniewang526 merged 1 commit intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
============================================
- Coverage 80.38% 80.38% -0.01%
- Complexity 1268 1270 +2
============================================
Files 79 79
Lines 6547 6570 +23
Branches 749 756 +7
============================================
+ Hits 5263 5281 +18
- Misses 891 893 +2
- Partials 393 396 +3
Continue to review full report at Codecov.
|
stephaniewang526
approved these changes
Oct 27, 2020
shollyman
approved these changes
Oct 27, 2020
Contributor
shollyman
left a comment
There was a problem hiding this comment.
Changes themselves look good, but let's update the description for this change to describe things a bit better. Perhaps "feat: support authorized UDF entries in dataset ACL" or similar.
Contributor
|
okay -- thank you @shollyman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.