Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

fix: fix start index with page size for list rows#793

Merged
stephaniewang526 merged 1 commit intogoogleapis:masterfrom
suraj-qlogic:java-bigquery-774
Oct 13, 2020
Merged

fix: fix start index with page size for list rows#793
stephaniewang526 merged 1 commit intogoogleapis:masterfrom
suraj-qlogic:java-bigquery-774

Conversation

@suraj-qlogic
Copy link
Copy Markdown
Contributor

Fixes #744

@suraj-qlogic suraj-qlogic requested a review from a team October 13, 2020 16:47
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 13, 2020

Codecov Report

Merging #793 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #793      +/-   ##
============================================
+ Coverage     80.40%   80.42%   +0.02%     
- Complexity     1265     1266       +1     
============================================
  Files            79       79              
  Lines          6532     6534       +2     
  Branches        745      746       +1     
============================================
+ Hits           5252     5255       +3     
+ Misses          889      888       -1     
  Partials        391      391              
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 83.03% <100.00%> (+0.19%) 85.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d786194...3dd9eb4. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 71e7d48 into googleapis:master Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery#listTableData & TableResult#iterateAll endless loop

2 participants