This repository was archived by the owner on Mar 23, 2026. It is now read-only.
feat: support for Table ACLs#653
Merged
stephaniewang526 merged 18 commits intogoogleapis:masterfrom Aug 25, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
============================================
- Coverage 81.49% 81.07% -0.43%
- Complexity 1226 1236 +10
============================================
Files 77 78 +1
Lines 6220 6329 +109
Branches 691 702 +11
============================================
+ Hits 5069 5131 +62
- Misses 792 833 +41
- Partials 359 365 +6
Continue to review full report at Codecov.
|
pmakani
approved these changes
Aug 24, 2020
Contributor
pmakani
left a comment
There was a problem hiding this comment.
LGTM!, except clir and codecov.
add clirr-ignored-differences.xml for new methods added to interfaces
stephaniewang526
approved these changes
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for table-level permissions to BigQuery, which is implemented via the IAM meta API.
There's three mechanisms exposed: getIamPolicy, setIamPolicy, and testIamPermissions.
The service exposes a service-centric version of the responses, so we include a policy converter to map to/from the more general cloud IAM messages.
Differences from the other veneer (java-storage):
changed the response format of TestIamPermissions. The general pattern is to pass in a resource (table) and a list of permissions to check, and it returns the subset of that permission list which the caller actually holds on the resource. The storage veneer chose to implement this as a list of bools instead, which is nonstandard.
Policy conversion is much more forgiving. In java-storage, it's only top-level resources which return policies, so there's an expectation that all responses have actual bindings. Tables in BQ are nested within other elements that also convey permissions, so it's far more common and likely to have empty bindings on policies.