fix: HttpResponse GZip content encoding equality change #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
reviewed
Oct 15, 2019
google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Show resolved
Hide resolved
google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Outdated
Show resolved
Hide resolved
google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Outdated
Show resolved
Hide resolved
…p-content-encoding # Conflicts: # google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Contributor
Author
Please see the latest commit. |
elharo
reviewed
Oct 19, 2019
google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Outdated
Show resolved
Hide resolved
google-http-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Show resolved
Hide resolved
elharo
reviewed
Oct 20, 2019
google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Outdated
Show resolved
Hide resolved
elharo
suggested changes
Oct 27, 2019
Contributor
elharo
left a comment
There was a problem hiding this comment.
The values should be case insensitive. See https://tools.ietf.org/html/rfc7230#section-3.2.4
"All transfer-coding names are case-insensitive". transfer-coding name is the name of the encoding such as gzip, not the name of HTTP header field.
elharo
reviewed
Oct 27, 2019
google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Outdated
Show resolved
Hide resolved
google-http-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Show resolved
Hide resolved
google-http-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Show resolved
Hide resolved
google-http-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Show resolved
Hide resolved
elharo
reviewed
Oct 27, 2019
google-http-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Outdated
Show resolved
Hide resolved
google-http-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Outdated
Show resolved
Hide resolved
elharo
approved these changes
Oct 29, 2019
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
… (googleapis#843) Source-Link: googleapis/synthtool@466412a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:7062473f423f339256346ddbee3d81fb1de6b784fabc2a4d959d7df2c720e375 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #842 by having HttpResponse compare (case insensitive) the content-encoding against "gzip" and "x-gzip" (HTTP 1.1).