fix: fix impersonated cred for gcloud #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) For IDTokenCredentials.refresh(self.request), use the provided request instead of creating a new one (2) For Credentials, only refresh the source credentials if it is not valid
busunkim96
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) For IDTokenCredentials.refresh(self.request), use the provided
request instead of creating a new one
(2) For impersonated_credentials.Credentials, only refresh the source credentials if it is not
valid (in other words, expires within _helpers.CLOCK_SKEW=5 minutes). Also we need to remove the
expiredfunction (because it doesn't support clock skew), so it can fall back to theexpiredfunction defined ingoogle.auth.credentials.Credentialsinterface which respect the clock skew.