fix: only require fast-text-encoding when needed (#740)

JustinBeckwith · web-flow · commit 04fcd77f5fc1 · 2019-06-25T10:28:00.000-07:00
diff --git a/src/crypto/browser/crypto.ts b/src/crypto/browser/crypto.ts
@@ -22,7 +22,7 @@ import * as base64js from 'base64-js';
 // Not all browsers support `TextEncoder`. The following `require` will
 // provide a fast UTF8-only replacement for those browsers that don't support
 // text encoding natively.
-if (typeof TextEncoder === 'undefined') {
+if (typeof process === 'undefined' && typeof TextEncoder === 'undefined') {
   require('fast-text-encoding');
 }
 
diff --git a/test/test.crypto.ts b/test/test.crypto.ts
@@ -73,4 +73,10 @@ describe('Node.js crypto tests', () => {
     const encodedString = crypto.encodeBase64StringUtf8(originalString);
     assert.strictEqual(encodedString, base64String);
   });
+
+  it('should not load fast-text-encoding while running in nodejs', () => {
+    const loadedModules = Object.keys(require('module')._cache);
+    const hits = loadedModules.filter(x => x.includes('fast-text-encoding'));
+    assert.strictEqual(hits.length, 0);
+  });
 });

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ import * as base64js from 'base64-js';`
`22`	`22`	// Not all browsers support `TextEncoder`. The following `require` will
`23`	`23`	`// provide a fast UTF8-only replacement for those browsers that don't support`
`24`	`24`	`// text encoding natively.`
`25`		`-if (typeof TextEncoder === 'undefined') {`
	`25`	`+if (typeof process === 'undefined' && typeof TextEncoder === 'undefined') {`
`26`	`26`	`require('fast-text-encoding');`
`27`	`27`	`}`
`28`	`28`