Skip to content

Conversation

@kanterov
Copy link

No description provided.

@kanterov kanterov requested a review from a team as a code owner October 18, 2019 12:32
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 18, 2019
@kanterov
Copy link
Author

@googlebot I signed it!

@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2019
@BenWhitehead
Copy link
Contributor

@kanterov The email used for the commits in this PR (you're github no-reply email) isn't registered with your CLA signing. I'm going to ping a teammate offline to see what we can do here.

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #371 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #371   +/-   ##
=========================================
  Coverage     79.67%   79.67%           
  Complexity      389      389           
=========================================
  Files            27       27           
  Lines          1761     1761           
  Branches        183      183           
=========================================
  Hits           1403     1403           
  Misses          262      262           
  Partials         96       96
Impacted Files Coverage Δ Complexity Δ
...m/google/auth/oauth2/ComputeEngineCredentials.java 83.45% <0%> (ø) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f02de9...fc58168. Read the comment docs.

@kanterov
Copy link
Author

@googlebot I signed it!

@kanterov
Copy link
Author

@BenWhitehead I fixed the email. As far as I know, my employer has signed CLA, but it didn't seem to work as well. I'm fine with closing this PR if you can do this 1 char change yourself because it doesn't seem to worth our time :)

BenWhitehead added a commit that referenced this pull request Oct 18, 2019
@BenWhitehead
Copy link
Contributor

Thanks for the contribution @kanterov and being flexible. I've opened #372 with the fix and passing cla check.

BenWhitehead added a commit that referenced this pull request Oct 18, 2019
@kanterov kanterov deleted the patch-1 branch October 18, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no This human has *not* signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants