Skip to content

fix: allow unset/null privateKeyId for JwtCredentials #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 4 commits into from
Aug 22, 2019
Merged

fix: allow unset/null privateKeyId for JwtCredentials #336

chingor13 merged 4 commits into from
Aug 22, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Aug 22, 2019 •
edited
Loading

Fixes #335

This was a regression from 0.16.2
Note that if you load Service Account Credentials from json, that field is required.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2019
@codecov
Copy link

codecov bot commented Aug 22, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@19f38ad). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #336   +/-   ##
=========================================
  Coverage          ?   79.67%           
  Complexity        ?      389           
=========================================
  Files             ?       27           
  Lines             ?     1761           
  Branches          ?      183           
=========================================
  Hits              ?     1403           
  Misses            ?      262           
  Partials          ?       96
Impacted Files Coverage Δ Complexity Δ
...tp/java/com/google/auth/oauth2/JwtCredentials.java 84.41% <100%> (ø) 13 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f38ad...1772ff1. Read the comment docs.

@chingor13 chingor13 marked this pull request as ready for review August 22, 2019 17:29
@chingor13 chingor13 requested a review from a team as a code owner August 22, 2019 17:29
@chingor13 chingor13 requested a review from kolea2 August 22, 2019 17:29
@chingor13 chingor13 merged commit d28a6ed into googleapis:master Aug 22, 2019
@chingor13 chingor13 deleted the jwt-without-private-key-id branch August 22, 2019 17:32
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@kolea2 kolea2 Awaiting requested review from kolea2

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ServiceAccountJwtCredentials throws NullPointerException

3 participants

@chingor13 @BenWhitehead @googlebot