Skip to content

closes bpo-46253: Change Py_UNICODE to Py_UCS4 in the C API docs to match the current source code#30387

Merged
benjaminp merged 3 commits into
python:mainfrom
juliangilbey:bpo-46253/c-api-unicode-argtype
Jan 11, 2022
Merged

closes bpo-46253: Change Py_UNICODE to Py_UCS4 in the C API docs to match the current source code#30387
benjaminp merged 3 commits into
python:mainfrom
juliangilbey:bpo-46253/c-api-unicode-argtype

Conversation

@juliangilbey

@juliangilbey juliangilbey commented Jan 4, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

As described in the bpo report, the C API Py_UNICODE_* macros documentation still used Py_UNICODE instead of Py_UCS4 as the argument type. This PR fixes this inconsistency.

https://bugs.python.org/issue46253

@the-knights-who-say-ni

the-knights-who-say-ni commented Jan 4, 2022

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@juliangilbey

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 4, 2022
@taleinat

taleinat commented Jan 8, 2022

Copy link
Copy Markdown
Contributor

Our kind bot Bedevere doesn't know this yet, but for docs-only changes we don't add a NEWS entry.

I've added the appropriate label; please remove the NEWS entry.

@juliangilbey

juliangilbey commented Jan 8, 2022

Copy link
Copy Markdown
Contributor Author

Hi @taleinat, do you have a preference whether I force-push this branch with the last commit removed or whether I use git revert instead?

@taleinat

taleinat commented Jan 8, 2022

Copy link
Copy Markdown
Contributor

Hi @juliangilbey,

I definitely prefer avoiding force-pushing branches with a PR.

git revert would be fine, or you can delete the file via the GitHub web UI.

@juliangilbey
Revert "📜🤖 Added by blurb_it."
053c1e4 
This reverts commit a860562.

Documentation-only changes do not require a NEWS item.
@juliangilbey

juliangilbey commented Jan 8, 2022

Copy link
Copy Markdown
Contributor Author

Hi @juliangilbey,

I definitely prefer avoiding force-pushing branches with a PR.

git revert would be fine, or you can delete the file via the GitHub web UI.

OK, done!

@benjaminp benjaminp changed the title bpo-46253: Change Py_UNICODE to Py_UCS4 in the C API docs to match the current source code closes bpo-46253: Change Py_UNICODE to Py_UCS4 in the C API docs to match the current source code Jan 11, 2022
@benjaminp benjaminp merged commit 43c5c13 into python:main Jan 11, 2022
@miss-islington

miss-islington commented Jan 11, 2022

Copy link
Copy Markdown
Contributor

Thanks @juliangilbey for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 11, 2022
@juliangilbey @miss-islington
closes bpo-46253: Change Py_UNICODE to Py_UCS4 in the C API docs to m…
dbb4421 
…atch the current source code (pythonGH-30387)

(cherry picked from commit 43c5c13)

Co-authored-by: Julian Gilbey <julian-git@d-and-j.net>
@bedevere-bot

bedevere-bot commented Jan 11, 2022

Copy link
Copy Markdown

GH-30533 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 11, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 11, 2022
@juliangilbey @miss-islington
closes bpo-46253: Change Py_UNICODE to Py_UCS4 in the C API docs to m…
55db281 
…atch the current source code (pythonGH-30387)

(cherry picked from commit 43c5c13)

Co-authored-by: Julian Gilbey <julian-git@d-and-j.net>
@bedevere-bot

bedevere-bot commented Jan 11, 2022

Copy link
Copy Markdown

GH-30534 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jan 11, 2022
@miss-islington @juliangilbey
closes bpo-46253: Change Py_UNICODE to Py_UCS4 in the C API docs to m…
4cfb109 
…atch the current source code (GH-30387)

(cherry picked from commit 43c5c13)

Co-authored-by: Julian Gilbey <julian-git@d-and-j.net>
miss-islington added a commit that referenced this pull request Jan 11, 2022
@miss-islington @juliangilbey
closes bpo-46253: Change Py_UNICODE to Py_UCS4 in the C API docs to m…
238a36b 
…atch the current source code (GH-30387)

(cherry picked from commit 43c5c13)

Co-authored-by: Julian Gilbey <julian-git@d-and-j.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp benjaminp approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

@malemburg malemburg Awaiting requested review from malemburg

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@juliangilbey @the-knights-who-say-ni @taleinat @miss-islington @bedevere-bot @benjaminp