Skip to content

Minor updates to reflect recommendations for Python support#10553

Merged
felicitymay merged 2 commits into
codeql-cli-2.11.0from
8032-python-2-deprecation
Sep 23, 2022
Merged

Minor updates to reflect recommendations for Python support#10553
felicitymay merged 2 commits into
codeql-cli-2.11.0from
8032-python-2-deprecation

Conversation

@felicitymay

@felicitymay felicitymay commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

Minor updates to the documentation to reflect our recommendation to use Python 3 to run the CodeQL extractor for Python analysis.

@felicitymay felicitymay added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Sep 23, 2022
@felicitymay felicitymay requested a review from tausbn September 23, 2022 10:43
tausbn
tausbn previously approved these changes Sep 23, 2022
View reviewed changes

@tausbn tausbn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

saritai
saritai approved these changes Sep 23, 2022
View reviewed changes

@saritai saritai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at it in local preview and looks good! ✨

@felicitymay

felicitymay commented Sep 23, 2022

Copy link
Copy Markdown
Contributor Author

@tausbn - not urgent, but just realized that I should probably retarget this PR against the codeql-cli-2.11.0 branch, so that the update is included in the changes that we'll publish to the CodeQL docs site with the 2.11.0 release.

@tausbn

tausbn commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

@tausbn - not urgent, but just realized that I should probably retarget this PR against the codeql-cli-2.11.0 branch, so that the update is included in the changes that we'll publish to the CodeQL docs site with the 2.11.0 release.

Ah yes, good point. Also, I made a suggestion for a change note here (in case you want to vet my verbose verbiage 😉).

@felicitymay felicitymay changed the base branch from main to codeql-cli-2.11.0 September 23, 2022 17:28
@felicitymay felicitymay requested review from a team as code owners September 23, 2022 17:28
@felicitymay

felicitymay commented Sep 23, 2022

Copy link
Copy Markdown
Contributor Author

Hmm. I'll fix up the commits locally.

@tausbn tausbn removed request for a team September 23, 2022 17:29
@tausbn

tausbn commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

Retargeting a PR is always a bit messy. I've removed the unnecessary review requests. My apologies to everyone for the notification spam!

@felicitymay

felicitymay commented Sep 23, 2022

Copy link
Copy Markdown
Contributor Author

I think I've got the rebase sorted out. I hope that I'm not going to ping everyone again 🤞🏻

@felicitymay felicitymay force-pushed the 8032-python-2-deprecation branch from 8d78aba to 8920d73 Compare September 23, 2022 17:44
@felicitymay felicitymay merged commit e963775 into codeql-cli-2.11.0 Sep 23, 2022
@felicitymay felicitymay deleted the 8032-python-2-deprecation branch September 23, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tausbn tausbn tausbn approved these changes

@saritai saritai saritai approved these changes

Assignees

No one assigned

Labels

documentation ready-for-doc-review This PR requires and is ready for review from the GitHub docs team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@felicitymay @tausbn @saritai @lecoursen @docubot