Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45554: Document multiprocessing.Process.exitcode values #30142

Merged
merged 2 commits into from Jan 18, 2022

Conversation

jmarshall
Copy link
Contributor

@jmarshall jmarshall commented Dec 16, 2021

This addresses bpo-45554 by expanding the exitcode documentation to also describe what exitcode will be in cases of normal termination, sys.exit() called, and on uncaught exceptions.

https://bugs.python.org/issue45554

Automerge-Triggered-By: GH:pitrou

@github-actions
Copy link

github-actions bot commented Jan 16, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2022
@zware zware removed the stale Stale PR or inactive for long period of time. label Jan 18, 2022
@zware zware requested review from applio and pitrou Jan 18, 2022
pitrou
pitrou approved these changes Jan 18, 2022
Copy link
Member

@pitrou pitrou left a comment

Sorry for the delay and thanks for the PR, this looks entirely good to me.

@pitrou pitrou added 🤖 automerge PR will be merged once it's been approved and all CI passed needs backport to 3.9 needs backport to 3.10 labels Jan 18, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jan 18, 2022

@jmarshall: Status check is done, and it's a success .

@miss-islington miss-islington merged commit 3852269 into python:main Jan 18, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jan 18, 2022

Thanks @jmarshall for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2022
…-30142)

This addresses [bpo-45554]() by expanding the `exitcode` documentation to also describe what `exitcode` will be in cases of normal termination, `sys.exit()` called, and on uncaught exceptions.

Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 3852269)

Co-authored-by: John Marshall <jmarshall@hey.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 18, 2022

GH-30674 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2022
…-30142)

This addresses [bpo-45554]() by expanding the `exitcode` documentation to also describe what `exitcode` will be in cases of normal termination, `sys.exit()` called, and on uncaught exceptions.

Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 3852269)

Co-authored-by: John Marshall <jmarshall@hey.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 18, 2022

GH-30675 is a backport of this pull request to the 3.9 branch.

@jmarshall jmarshall deleted the doc/exitcode branch Jan 18, 2022
@jmarshall
Copy link
Contributor Author

jmarshall commented Jan 18, 2022

Thanks @zware and @pitrou for taking the time to review this. 🎉

miss-islington added a commit that referenced this pull request Jan 18, 2022
This addresses [bpo-45554]() by expanding the `exitcode` documentation to also describe what `exitcode` will be in cases of normal termination, `sys.exit()` called, and on uncaught exceptions.

Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 3852269)

Co-authored-by: John Marshall <jmarshall@hey.com>
miss-islington added a commit that referenced this pull request Jan 18, 2022
…-30142) (GH-30675)

This addresses [[bpo-45554]()]() by expanding the `exitcode` documentation to also describe what `exitcode` will be in cases of normal termination, `sys.exit()` called, and on uncaught exceptions.


(cherry picked from commit 3852269)


Co-authored-by: John Marshall <jmarshall@hey.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…thonGH-30142) (pythonGH-30675)

This addresses [[bpo-45554]()]() by expanding the `exitcode` documentation to also describe what `exitcode` will be in cases of normal termination, `sys.exit()` called, and on uncaught exceptions.


(cherry picked from commit 3852269)


Co-authored-by: John Marshall <jmarshall@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants