This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Performance: Fix bad join ordering#547
Merged
smowton merged 1 commit intogithub:mainfrom Jun 21, 2021
Merged
Conversation
smowton
approved these changes
Jun 21, 2021
| @@ -1163,20 +1163,23 @@ abstract class BarrierGuard extends Node { | |||
| * Holds if `guard` markes a point in the control-flow graph where this node | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * Holds if `guard` markes a point in the control-flow graph where this node | |
| * Holds if `guard` marks a point in the control-flow graph where this node |
You could fix this typo while you're at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
pragma[noopt]to force the current join ordering for theguardspredicate in theDataFlowUtillibrary. This is necessary because of an upcoming change to the optimiser (computing size estimates fornewtypes) that will unfortunately lead to a bad choice of join ordering in this case.cc. @github/codeql-core