You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change the CodeQL engine caused a major performance regression in the Java dataflow library due to a change in join ordering. This PR adds two pragma[only_bind_into] annotations which should fix the performance issue.
Don't wait on this PR -- Go is behind a few other recent dataflow lib changes anyhow, so we'll check out the performance of them all combined and bring it forwards when some spare time presents itself.
Stages 2, 3, and 4 in DataFlowImpl.qll should be synced - i.e. DataFlowImpl::Stage3::parameterMayFlowThrough and DataFlowImpl::Stage4::parameterMayFlowThrough should be updated as well. These are manually desugared parameterised module applications, so keeping them synced is completely manual.
Stages 2, 3, and 4 in DataFlowImpl.qll should be synced - i.e. DataFlowImpl::Stage3::parameterMayFlowThrough and DataFlowImpl::Stage4::parameterMayFlowThrough should be updated as well. These are manually desugared parameterised module applications, so keeping them synced is completely manual.
Ah I see, thank you. I've done this and squashed the commits to keep the commit log tidier.
⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. A recent commit removed the previously reported differences.
The head of this PR and the base branch were compared for differences in the framework coverage reports. A recent commit removed the previously reported differences.
@tamasvajk This looks like a bug in the action: There were no previously reported differences, no commits on this PR ever affected framework coverage.
The head of this PR and the base branch were compared for differences in the framework coverage reports. A recent commit removed the previously reported differences.
@tamasvajk This looks like a bug in the action: There were no previously reported differences, no commits on this PR ever affected framework coverage.
@aschackmull Yes, sorry for this noise. The previous PR analysis was done with an earlier version of the workflow, and one of the artifacts is missing, which is now expected by the job. This will impact PRs that were opened before the current version of the workflow was merged. I'll adjust the script to be backwards compatible.
Differences jobs look good to me! Java has a massive speedup (as expected since this change was targetted to fix a performance regression there), and the other languages look mostly unchanged.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change the CodeQL engine caused a major performance regression in the Java dataflow library due to a change in join ordering. This PR adds two
pragma[only_bind_into]annotations which should fix the performance issue.cc. @github/codeql-core