Skip to content

gh-124962: Convert leftover rst to markup in InternalDocs/compiler.md #124971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

isaacjones99
Copy link
Contributor

@isaacjones99 isaacjones99 commented Oct 4, 2024

Changes some lines of leftover rst to markup in the Compiler internal document.

@ghost
Copy link

ghost commented Oct 4, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Oct 4, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the double empty lines before and after the triple back-ticks.

isaacjones99 and others added 2 commits October 4, 2024 13:27
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
Copy link
Member

picnixz commented Oct 4, 2024

Thank you for this! (sorry for the wrong suggestions). We'll just wait for a committer to accept your changes! (cc @Eclips4)

@picnixz picnixz changed the title gh-124962: Convert leftover rst to markup gh-124962: Convert leftover rst to markup in InternalDocs/compiler.md Oct 4, 2024
@isaacjones99
Copy link
Contributor Author

Thank you for this! (sorry for the wrong suggestions). We'll just wait for a committer to accept your changes! (cc @Eclips4)

Not a problem - Thank you for your help.

@kumaraditya303 kumaraditya303 merged commit 994051e into python:main Oct 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants