bpo-33239: Fix default value of 'buffering' parameter in docs of tempfile.* functions#21763
Merged
miss-islington merged 1 commit intopython:masterfrom Sep 13, 2020
Merged
Conversation
Member
|
This seems to have been reported already though the PR has unresolved review comments : https://bugs.python.org/issue33239 |
Member
|
Travis job seems to be stalled, so I will close and reopen this PR. |
vsajip
approved these changes
Sep 13, 2020
Contributor
|
Thanks @sir-sigurd for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
Thanks @sir-sigurd for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2020
…file.* functions (pythonGH-21763) `None` doesn't work: ```python >>> import tempfile >>> tempfile.TemporaryFile(buffering=None) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/sergey/tmp/cpython-dev/Lib/tempfile.py", line 607, in TemporaryFile return _io.open(fd, mode, buffering=buffering, TypeError: 'NoneType' object cannot be interpreted as an integer ``` Automerge-Triggered-By: @vsajip (cherry picked from commit b48389d) Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
|
GH-22225 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2020
…file.* functions (pythonGH-21763) `None` doesn't work: ```python >>> import tempfile >>> tempfile.TemporaryFile(buffering=None) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/sergey/tmp/cpython-dev/Lib/tempfile.py", line 607, in TemporaryFile return _io.open(fd, mode, buffering=buffering, TypeError: 'NoneType' object cannot be interpreted as an integer ``` Automerge-Triggered-By: @vsajip (cherry picked from commit b48389d) Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
|
GH-22226 is a backport of this pull request to the 3.8 branch. |
vsajip
pushed a commit
that referenced
this pull request
Sep 13, 2020
vsajip
pushed a commit
that referenced
this pull request
Sep 13, 2020
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
…file.* functions (pythonGH-21763) `None` doesn't work: ```python >>> import tempfile >>> tempfile.TemporaryFile(buffering=None) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/sergey/tmp/cpython-dev/Lib/tempfile.py", line 607, in TemporaryFile return _io.open(fd, mode, buffering=buffering, TypeError: 'NoneType' object cannot be interpreted as an integer ``` Automerge-Triggered-By: @vsajip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nonedoesn't work:https://bugs.python.org/issue33239
Automerge-Triggered-By: @vsajip