Util: Add shared file system implementation#12289
Merged
hvitved merged 2 commits intogithub:mainfrom Feb 24, 2023
Merged
Conversation
de0fb91 to
b522dff
Compare
b522dff to
ad37523
Compare
| result.getStem() = stem and | ||
| result.getExtension() = extension | ||
| } | ||
| predicate hasSourceLocationPrefix = sourceLocationPrefix/1; |
Check warning
Code scanning / CodeQL
QL-for-QL encountered an internal consistency error
| string getStem() { | ||
| result = this.getAbsolutePath().regexpCapture(".*/([^/]*?)(?:\\.([^.]*))?", 1) | ||
| } | ||
| predicate hasSourceLocationPrefix = sourceLocationPrefix/1; |
Check warning
Code scanning / CodeQL
QL-for-QL encountered an internal consistency error
Contributor
Author
Certainly looks very similar; I wonder why it was dropped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids duplicating the logic and documentation for file system predicates.
This PR applies the new shared implementation to C# and Ruby only. I encourage other languages to follow suit (ping @github/codeql-swift , @github/codeql-c , @github/codeql-go , @github/codeql-java , @github/codeql-python, @github/codeql-javascript ).